Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create plot for inspecting the data #24

Merged
merged 31 commits into from
Aug 13, 2024
Merged

create plot for inspecting the data #24

merged 31 commits into from
Aug 13, 2024

Conversation

gcroci2
Copy link
Contributor

@gcroci2 gcroci2 commented Jul 30, 2024 •
edited
Loading

This PR adds a graph in the layout and in the gm_plot callback. It visualizes the number of BGCs in function of the number of GCFs, allowing the user to inspect the GCFs' IDs corresponding to a certain number of BGCs.

Possible improvements:

  • Disable the tabs every time that the user presses the upload button. As it is now, the last file uploaded is kept visualized on the dashboard until the new upload is not over.
  • Speeding up/handling better the waiting time in the plotting process. With big files, it now takes ~20s to be plotted. I could investigate if it's possible to speed it up, and in case it's not straight-forward I can add a meaningful waiting message for the user before the data are plotted (but after they're uploaded).
  • Add a test for the graph. Not sure how meaningful this would be in this specific case.

Do we want to do this in this PR or should I open separate PRs for the future? It depends on what we wish to prioritize at the moment.

@gcroci2 Graphite App
Copy link
Contributor Author

gcroci2 commented Jul 30, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @gcroci2 and the rest of your teammates on Graphite Graphite

@gcroci2 gcroci2 changed the title add graph for gm tab create plot for inspecting the data Jul 30, 2024
@gcroci2 gcroci2 marked this pull request as ready for review July 30, 2024 16:00
@gcroci2 gcroci2 marked this pull request as draft July 30, 2024 16:01
@gcroci2 gcroci2 self-assigned this Jul 30, 2024
@gcroci2 gcroci2 marked this pull request as ready for review July 30, 2024 16:07
CunliangGeng
CunliangGeng approved these changes Jul 31, 2024
View reviewed changes
app/callbacks.py Outdated Show resolved Hide resolved
app/callbacks.py Outdated Show resolved Hide resolved
app/callbacks.py Outdated Show resolved Hide resolved
@CunliangGeng
Copy link
Member

CunliangGeng commented Jul 31, 2024 •
edited
Loading

As for the "Possible improvements", it makes sense to improve the first two points. Better to do that in independent PRs. Graphites has been enabled in this repo, you could use it to manage stacked PR with ease (https://graphite.dev/docs/cli-quick-start)

@gcroci2
Copy link
Contributor Author

gcroci2 commented Aug 9, 2024

As for the "Possible improvements", it makes sense to improve the first two points. Better to do that in independent PRs. Graphites has been enabled in this repo, you could use it to manage stacked PR with ease (https://graphite.dev/docs/cli-quick-start)

I opened #27 and #28

Base automatically changed from 18_genomics_filter_gcroci2 to main August 13, 2024 08:48
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Aug 13, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@gcroci2 gcroci2 merged commit d63ffe7 into main Aug 13, 2024
4 checks passed
@gcroci2 gcroci2 deleted the 20_plot_inspecting_data_gcroci2 branch August 13, 2024 09:05
@gcroci2 gcroci2 linked an issue Aug 13, 2024 that may be closed by this pull request
Create plot for inspecting the data #20
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CunliangGeng CunliangGeng CunliangGeng approved these changes

Assignees

@gcroci2 gcroci2

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create plot for inspecting the data
2 participants
@gcroci2 @CunliangGeng